Define status data type with matching exit codes #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninioArtillero
force-pushed
the
ninioArtillero/exit-codes
branch
3 times, most recently
from
cf85bbb to
e9aecbc
Compare
isovector
requested changes
Nov 12, 2025
Collaborator
isovector
left a comment
isovector
left a comment
There was a problem hiding this comment.
Not quite there. I propose splitting out the first three constructors from StatusFlag and moving them into Status.
ouroboros-consensus-diffusion/app/conformance-test-runner/Main.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-diffusion/app/conformance-test-runner/Main.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-diffusion/app/conformance-test-runner/Main.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-diffusion/app/conformance-test-runner/Main.hs
Outdated
Show resolved
Hide resolved
ninioArtillero
force-pushed
the
ninioArtillero/exit-codes
branch
from
6e13579 to
95a4880
Compare
isovector
requested changes
Nov 12, 2025
ouroboros-consensus-diffusion/app/conformance-test-runner/Main.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-diffusion/app/conformance-test-runner/Main.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-diffusion/app/conformance-test-runner/Main.hs
Outdated
Show resolved
Hide resolved
ninioArtillero
force-pushed
the
ninioArtillero/exit-codes
branch
from
79b606c to
db03bcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes tweag/cardano-conformance-testing-of-consensus#43
This PR defines a data type with exit codes as defined in our
design document.