Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove redundant Bazel configuration names #2088

Merged
merged 2 commits into from
Jan 4, 2024
Merged

chore: remove redundant Bazel configuration names #2088

merged 2 commits into from
Jan 4, 2024

Conversation

cgrindel
Copy link
Contributor

  • Remove ci-linux-* and ci-macos-* as they merely applied their respective linux-* and macos-* configuration names.

Related to #2087.

@cgrindel cgrindel self-assigned this Dec 19, 2023
@avdv
Copy link
Member

avdv commented Dec 21, 2023

Could you also remove those from the .bazelci/presubmit.yml config?

@cgrindel
Copy link
Contributor Author

Could you also remove those from the .bazelci/presubmit.yml config?

It appears that they are not referenced there. I just did a search for ci-linux- and ci-macos-. There were no results.

@cgrindel cgrindel marked this pull request as ready for review January 3, 2024 14:45
@cgrindel cgrindel requested a review from avdv as a code owner January 3, 2024 14:45
avdv
avdv approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove those from the .bazelci/presubmit.yml config?

It appears that they are not referenced there. I just did a search for ci-linux- and ci-macos-. There were no results.

You're right. I don't know where dreamed that up...

LGTM, thank you!

@cgrindel cgrindel added the merge-queue merge on green CI label Jan 4, 2024
@mergify mergify bot merged commit b2baa5f into master Jan 4, 2024
106 checks passed
@mergify mergify bot deleted the cg/use_write_bazelrc branch January 4, 2024 19:06
@mergify mergify bot removed the merge-queue merge on green CI label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdv avdv avdv approved these changes

Assignees

@cgrindel cgrindel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgrindel @avdv