Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable flaky test that fails with ExitFailure (-9) #2096

Merged
merged 37 commits into from
Jan 8, 2024

Conversation

cgrindel
Copy link
Contributor

@cgrindel cgrindel commented Dec 21, 2023

Per this conversation, to prevent out-of-memory (OOM) errors, we will shut down Bazel servers started by RunTests.hs. Unfortunately, we still see occasional Exit Code: ExitFailure (-9) errors. Printing the memory/process information in CI will provide additional details when/if it occurs, again.

  • Refactor RunTests.hs so that tests for each workspace live under a separate describe.
  • Add afterAll_ hook to shutdown Bazel after all of the tests for a workspace.
  • Add around_ hook to print memory/process information before and after each test. This is enabled by setting the environment variable RHT_PRINT_MEMORY to true.
  • For now, disable the flaky test.

Related to #2089.

@cgrindel cgrindel marked this pull request as ready for review January 4, 2024 17:37
@cgrindel cgrindel requested a review from avdv January 4, 2024 22:10
Copy link
Member

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, otherwise LGTM.

@cgrindel cgrindel added merge-queue merge on green CI and removed merge-queue merge on green CI labels Jan 5, 2024
@cgrindel cgrindel added merge-queue merge on green CI and removed merge-queue merge on green CI labels Jan 5, 2024
@cgrindel cgrindel changed the title chore: shutdown Bazel servers launched by RunTests.hs chore: disable flaky test that fails with ExitFailure (-9) Jan 5, 2024
@cgrindel cgrindel requested a review from avdv January 5, 2024 22:23
@cgrindel
Copy link
Contributor Author

cgrindel commented Jan 5, 2024

@avdv For now, I recommend that we disable the test that exhibits the error. I will continue my investigation. However, these errors are hindering other work items. Hence, I am asking for another code review.

@cgrindel cgrindel merged commit 69f2427 into master Jan 8, 2024
49 checks passed
@cgrindel cgrindel deleted the cg/more_oom_fixes branch January 8, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants