macOS CI fixes #188
Merged
macOS CI fixes #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current nixpkgs doesn't support macOS Big Sur (11). Its support landed in nixpkgs in 21.11, but that also broke support for Catalina (10.15), so switch CI workflow to use "macos-11" runner. Fixes #175
On CI we set NIX_PATH to "nixpkgs=./nixpkgs.nix", so nix-shell tries to use it from within the example's directory and fails, it tries to use builtin bash. On macOS it is too old, so we should make sure that the one from nixpkgs is used. Related to #176
|
For some reason GitHub expects build that is removed in this PR (the |
AleksanderGondek
suggested changes
Feb 19, 2022
YorikSar
force-pushed
the
yuriy.taraday/fix-macos-ci
branch
from
b206f91
to
5110ff1
Compare
This was a branch protection setting. I've changed it to point to macos-11 |
|
Thank you @YorikSar for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macos-11builder testsmacos-11builder for examples, excluding Python and Rust ones (see Python example tries to run as bash script on macOS #186 and Rust example fails to compile on macOS because of libiconv #187)This should close #175 and #176.