Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #4: Support for installing split APKs #52

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Fixes #4: Support for installing split APKs #52

merged 3 commits into from
Mar 29, 2023

Conversation

baltpeter
Copy link
Member

This is based on #42.

@baltpeter baltpeter requested a review from zner0L March 28, 2023 09:12
@baltpeter
Copy link
Member Author

This PR makes path.ts in CA obsolete. We can just get rid of that once this is merged.

@baltpeter baltpeter marked this pull request as draft March 28, 2023 14:03
@baltpeter baltpeter mentioned this pull request Mar 28, 2023
Closed
@baltpeter
Copy link
Member Author

I noticed a problem with the current implementation that I need to fix before this can be merged: #4 (comment)

@baltpeter baltpeter marked this pull request as ready for review March 28, 2023 14:42
@baltpeter
Copy link
Member Author

Fixed now.

zner0L
zner0L previously approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@zner0L zner0L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, thank you!

@baltpeter @zner0L
parseAppMeta: Don't assume that ID and version are non-empty on Android
43a9db9 
The version for example is empty for additional split APKs, see:
#4 (comment)
@baltpeter @zner0L
parseAppMeta: Also parse name, versionCode, and architectures
2e951be
@baltpeter @zner0L
Fixes #4: Support for installing split APKs
8cab6c2 
APKs not supported on the device's architecture are filtered out.

This commit also adds a few additional checks to make installing apps
on Android more robust.
@zner0L zner0L merged commit 9d67d26 into main Mar 29, 2023
@zner0L zner0L deleted the b_split-apks branch March 29, 2023 14:44
zner0L added a commit to tweaselORG/cyanoacrylate that referenced this pull request Mar 31, 2023
@zner0L
Update appstraction and remove path.ts
cbe81c8 
@baltpeter suggested this in tweaselORG/appstraction#52 (comment).
zner0L added a commit to tweaselORG/cyanoacrylate that referenced this pull request Mar 31, 2023
@zner0L
Update appstraction and remove path.ts
c5077fd 
@baltpeter suggested this in tweaselORG/appstraction#52 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zner0L zner0L zner0L left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baltpeter @zner0L