This repository has been archived by the owner on Oct 3, 2024. It is now read-only.
Allow user with multiple roles, add UserManager role #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
- Coverage 62.39% 61.50% -0.89%
==========================================
Files 28 28
Lines 3438 3484 +46
==========================================
- Hits 2145 2143 -2
- Misses 1293 1341 +48 ☔ View full report in Codecov by Sentry. |
tdittr
suggested changes
Aug 20, 2024
openadr-vtn/src/jwt.rs
Outdated
| .collect() | ||
| } | ||
|
|
||
| pub fn business_ids(&self) -> (Vec<String>, bool) { |
There was a problem hiding this comment.
Would this be better as an enum Foo {Any, Specific(Vec<String>)}?
There was a problem hiding this comment.
Good idea! Will change!
| } | ||
|
|
||
| impl Claims { | ||
| pub fn ven_ids(&self) -> Vec<String> { |
There was a problem hiding this comment.
Could this be a new-type instead of String?
There was a problem hiding this comment.
Probably will be a newtype eventually, given we already have several of those, but I wanted to keep this PR a little smaller.
tdittr
approved these changes
Aug 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the first part of #82 I added the ability to add multiple roles specifically to allow creating a kind of superuser account for testing purposes.