Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take keys by reference #59

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Take keys by reference #59

merged 2 commits into from
Jul 17, 2024

Conversation

diondokter
Copy link
Collaborator

Fixes #58

Copy link

PR build size

  text	   data	    bss	    dec	    hex	filename
 16700	     56	  33808	  50564	   c584	example

Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +55%     +21  [ = ]       0    [Unmapped]
  -0.3%     -32  [ = ]       0    .debug_aranges
  -0.5%    -112  [ = ]       0    .debug_frame
  -2.4%    -192  [ = ]       0    .symtab
  -0.3%    -389  [ = ]       0    .debug_loc
  -0.9%    -472  [ = ]       0    .debug_ranges
  -3.0%    -504  -3.0%    -504    .text
  -0.7%    -540  [ = ]       0    .debug_line
  -7.6% -1.39Ki  [ = ]       0    .strtab
  -0.7% -2.30Ki  [ = ]       0    .debug_info
  -0.9% -2.40Ki  [ = ]       0    .debug_str
  -0.9% -8.25Ki  -1.0%    -504    TOTAL

Copy link

PR build size

  text	   data	    bss	    dec	    hex	filename
 16700	     56	  33808	  50564	   c584	example

Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +61%     +23  [ = ]       0    [Unmapped]
  -0.3%     -32  [ = ]       0    .debug_aranges
  -0.5%    -112  [ = ]       0    .debug_frame
  -2.4%    -192  [ = ]       0    .symtab
  -0.3%    -389  [ = ]       0    .debug_loc
  -0.9%    -472  [ = ]       0    .debug_ranges
  -3.0%    -504  -3.0%    -504    .text
  -0.7%    -554  [ = ]       0    .debug_line
  -7.6% -1.39Ki  [ = ]       0    .strtab
  -0.7% -2.32Ki  [ = ]       0    .debug_info
  -0.9% -2.40Ki  [ = ]       0    .debug_str
  -0.9% -8.29Ki  -1.0%    -504    TOTAL

@diondokter diondokter merged commit 9912929 into master Jul 17, 2024
5 checks passed
@diondokter diondokter deleted the keys-by-ref branch July 17, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map should take Key by reference
1 participant