refactor(ui/settings): update styles and improve structure #10201
+6
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted border color in SettingsRadioCard for better visual hierarchy. Simplified grid template layout in SSO form for consistency. Enhanced HorizontalSeparator by wrapping text in Label for improved accessibility and styling.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances UI components in the settings area, focusing on accessibility, visual hierarchy, and layout simplification across multiple components.
- Improved accessibility in
/packages/twenty-ui/src/display/text/components/HorizontalSeparator.tsxby wrapping text content in a Label component - Enhanced visual contrast in
/packages/twenty-front/src/modules/settings/components/SettingsRadioCard.tsxby updating border color from 'light' to 'medium' - Streamlined grid layout in
/packages/twenty-front/src/modules/settings/security/components/SettingsSSOIdentitiesProvidersForm.tsxby removing unused grid areas
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-ui/src/display/text/components/HorizontalSeparator.tsx
Outdated
Show resolved
Hide resolved
…ator.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Removed redundant parentheses around the Label component to improve code clarity and correctness. This change has no impact on functionality but simplifies the code structure.
FelixMalfait
approved these changes
Feb 14, 2025
|
Great! |
|
Thanks @AMoreaux for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted border color in SettingsRadioCard for better visual hierarchy. Simplified grid template layout in SSO form for consistency. Enhanced HorizontalSeparator by wrapping text in Label for improved accessibility and styling.
Fix twentyhq/core-team-issues#385 (comment)