Fix command menu selection #10248
Merged
Fix command menu selection #10248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesBochet
approved these changes
Feb 17, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces a new Recoil state to track user selections in the command menu, improving the default selection behavior and preventing unwanted selection resets.
- Added
hasUserSelectedCommandStatein/packages/twenty-front/src/modules/command-menu/states/hasUserSelectedCommandState.tsto track user selection state - Modified
CommandMenuDefaultSelectionEffectto only auto-select first item when no manual selection exists - Integrated selection state management across command menu operations (open, close, navigate) in
useCommandMenu.ts - Enhanced
SelectableListcomponent withonSelectcallback to track keyboard navigation selections - Updated selection reset logic to properly handle menu redirections and closures
6 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
eliezer-rodrigues037
pushed a commit
to mind-developer/kvoip-v2
that referenced
this pull request
Feb 17, 2025
- Created a state `hasUserSelectedCommandState` : This state is set to `true` when the user selects an element in the command menu list. It is set to false upon redirection or when the command menu is closed. - Modified `CommandMenuDefaultSelectionEffect` to have the expected selection behavior for the command menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasUserSelectedCommandState: This state is set totruewhen the user selects an element in the command menu list. It is set to false upon redirection or when the command menu is closed.CommandMenuDefaultSelectionEffectto have the expected selection behavior for the command menu