refactor(entities): centralize base entity fields #10287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted common fields (id, createdAt, updatedAt, deletedAt) into abstract base classes BaseEntity and BaseSoftDeleteEntity. Updated various entities to inherit from these classes, reducing redundancy and improving maintainability.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Introduced abstract base classes to centralize common entity fields across the codebase, improving code maintainability and reducing duplication in the Twenty server.
- Added new
src/engine/utils/base-entities-fields.tswithBaseEntityandBaseSoftDeleteEntityclasses to handle common fields (id, timestamps) - Refactored
WorkspaceSSOIdentityProvider,AppToken,User, andWorkspaceentities to inherit from base classes - Maintained unique email index with
deletedAtcondition inUserentity - Preserved GraphQL decorators and TypeORM relationships across all modified entities
- Ensured proper field types with
timestamptzfor all date columns
5 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
33
to
35
| @OneToMany(() => AppToken, (appToken) => appToken.workspace, { | ||
| cascade: true, | ||
| }) |
There was a problem hiding this comment.
style: cascade:true with onDelete:CASCADE in other relations may cause duplicate cascade operations
Comment on lines
+30
to
+32
| @Field({ nullable: true }) | ||
| @DeleteDateColumn({ name: 'deletedAt', type: 'timestamptz' }) | ||
| deletedAt: Date; |
There was a problem hiding this comment.
logic: deletedAt field should be nullable in the database column as well. Add nullable: true to @DeleteDateColumn options
Suggested change
| @Field({ nullable: true }) | |
| @DeleteDateColumn({ name: 'deletedAt', type: 'timestamptz' }) | |
| deletedAt: Date; | |
| @Field({ nullable: true }) | |
| @DeleteDateColumn({ name: 'deletedAt', type: 'timestamptz', nullable: true }) | |
| deletedAt: Date; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted common fields (id, createdAt, updatedAt, deletedAt) into abstract base classes BaseEntity and BaseSoftDeleteEntity. Updated various entities to inherit from these classes, reducing redundancy and improving maintainability.