Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix server ci integration #10296

Merged
merged 6 commits into from
Feb 18, 2025
Merged

fix server ci integration #10296

merged 6 commits into from
Feb 18, 2025

Conversation

Weiko
Copy link
Member

@Weiko Weiko commented Feb 18, 2025

Now that the CI is running, I'm trying to fix the tests

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Modifications to improve server CI integration by adjusting query limits and enhancing database setup configuration for testing.

  • Reduced QUERY_MAX_RECORDS from 100 to 60 in /packages/twenty-server/src/engine/api/graphql/graphql-query-runner/constants/query-max-records.constant.ts to optimize test performance
  • Added workspace seeding step npx nx run twenty-server:workspace:seed:dev in CI workflow for integration tests
  • Moved database URL configuration to environment variables block in CI for better organization
  • Added artifact upload for reset-logs in CI for better debugging capabilities

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

prastoin
prastoin previously approved these changes Feb 18, 2025
Copy link
Contributor

@prastoin prastoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool !
Just a little regarding above build steps, unless I'm mistaken we could remove this step

      - name: Build dependencies
        run: |
          npx nx build twenty-shared
          npx nx build twenty-emails

@prastoin prastoin self-requested a review February 18, 2025 15:23
@prastoin prastoin dismissed their stale review February 18, 2025 15:25

Wanted to left a comment in the firs place :p

@Weiko Weiko merged commit 5cf0a71 into main Feb 18, 2025
31 checks passed
@Weiko Weiko deleted the c--fix-server-ci-integration branch February 18, 2025 16:01
@Weiko Weiko restored the c--fix-server-ci-integration branch February 18, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants