Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feedback from Thomas #10297

Merged
merged 3 commits into from
Feb 18, 2025
Merged

feedback from Thomas #10297

merged 3 commits into from
Feb 18, 2025

Conversation

guillim
Copy link
Contributor

@guillim guillim commented Feb 18, 2025

@guillim guillim enabled auto-merge (squash) February 18, 2025 15:27
@guillim guillim self-assigned this Feb 18, 2025
@guillim guillim added scope: front Issues that are affecting the frontend side only -PR: awaiting review prio: med labels Feb 18, 2025
greptile-apps[bot]
greptile-apps bot reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Modified AvatarChip component to use smaller icon sizes for better visual consistency in the UI.

  • Changed icon size from 'md' to 'sm' in packages/twenty-ui/src/display/chip/components/AvatarChip.tsx for both inverted and non-inverted LeftIcon variants

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@Devessier Devessier self-requested a review February 18, 2025 16:02
Devessier
Devessier approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@Devessier Devessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@guillim
Copy link
Contributor Author

guillim commented Feb 18, 2025

Please @Weiko , a rage approve 😸

@FelixMalfait FelixMalfait merged commit 8d8bd4a into main Feb 18, 2025
43 of 47 checks passed
@FelixMalfait FelixMalfait deleted the icon-size-fix branch February 18, 2025 18:05
@github-actions GitHub Actions
Copy link
Contributor

Thanks @guillim for your contribution!
This marks your 68th PR on the repo. You're top 1% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@Devessier Devessier Devessier approved these changes

Assignees

@guillim guillim

Labels
-PR: awaiting author prio: med scope: front Issues that are affecting the frontend side only
Projects
🎯 Roadmap & Sprints
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guillim @Devessier @FelixMalfait