feat(settings-security): add feature flag for trusted domains #10338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new feature flag, IsTrustedDomainsEnabled, to control the visibility of the trusted domains section in security settings. Updated back-end seeds, enums, and front-end logic to support this change.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds a new feature flag IsTrustedDomainsEnabled to control the visibility of trusted domains functionality in the security settings section.
- Added new feature flag in
/packages/twenty-server/src/database/typeorm-seeds/core/feature-flags.tswith default valuefalse - Implemented conditional rendering in
/packages/twenty-front/src/pages/settings/security/SettingsSecurity.tsxusing the new feature flag - Added
IsTrustedDomainsEnabledtoFeatureFlagKeyenum in/packages/twenty-server/src/engine/core-modules/feature-flag/enums/feature-flag-key.enum.ts - Updated GraphQL types in
/packages/twenty-front/src/generated/graphql.tsxto include the new feature flag
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/pages/settings/security/SettingsSecurity.tsx
Outdated
Show resolved
Hide resolved
…ture-flag-for-trusted-domains
Introduce a new enum flag IsTrustedDomainsEnabled in the GraphQL metadata. This addition supports feature toggling for trusted domain functionality.
…ture-flag-for-trusted-domains
FelixMalfait
approved these changes
Feb 20, 2025
packages/twenty-server/src/database/typeorm-seeds/core/feature-flags.ts
Outdated
Show resolved
Hide resolved
…ture-flag-for-trusted-domains # Conflicts: # packages/twenty-front/src/pages/settings/security/SettingsSecurity.tsx
Renamed the feature flag key IsTrustedDomainsEnabled to IsApprovedAccessDomainsEnabled across the codebase. Updated all relevant enums, seeds, GraphQL types, and usage references to align with the new terminology. This change improves clarity and better reflects the intended functionality.
…d-domains' into feat/add-feature-flag-for-trusted-domains
Removed the WorkspaceTrustedDomainResolver and WorkspaceTrustedDomainService, along with their associated methods and dependencies. This change simplifies the codebase by eliminating unused or redundant functionality.
…ture-flag-for-trusted-domains
…ture-flag-for-trusted-domains
…ture-flag-for-trusted-domains
…10346) Added support for validating trusted domains during user sign-in and sign-up processes. Updated services to check trusted domains and ensure proper access control. Adjusted tests and mocks to align with the new functionality.
AMoreaux
merged commit 6fbb8b6
into
feat/frontend-manage-trusted-domains
45 checks passed
|
Thanks @AMoreaux for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new feature flag, IsTrustedDomainsEnabled, to control the visibility of the trusted domains section in security settings. Updated back-end seeds, enums, and front-end logic to support this change.