Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no-single-variables-to-translate eslint rule #10341

Merged

Conversation

Weiko
Copy link
Member

@Weiko Weiko commented Feb 19, 2025

Context

This rule crashes the FE for some reason, disabling it for now

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Disabled the lingui/no-single-variables-to-translate ESLint rule to resolve frontend crashes, while modifying RolePermissions component props structure.

  • Turned off lingui/no-single-variables-to-translate rule in /.eslintrc.cjs to fix frontend crashes
  • Modified packages/twenty-front/src/pages/settings/roles/components/RolePermissions.tsx props type to be more specific with Role properties
  • Added unused workspaceMembers array to RolePermissions component that may need implementation or removal

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines +28 to +32
type RolePermissionsProps = {
role: Pick<Role, 'id' | 'label' | 'canUpdateAllSettings'> & {
workspaceMembers: Array<WorkspaceMember>;
};
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: workspaceMembers is added to props but never used in the component

Suggested change
type RolePermissionsProps = {
role: Pick<Role, 'id' | 'label' | 'canUpdateAllSettings'> & {
workspaceMembers: Array<WorkspaceMember>;
};
};
type RolePermissionsProps = {
role: Pick<Role, 'id' | 'label' | 'canUpdateAllSettings'>;
};

@FelixMalfait FelixMalfait merged commit 202af87 into main Feb 19, 2025
44 of 46 checks passed
@FelixMalfait FelixMalfait deleted the c--remove-lingui-no-single-variables-to-translate branch February 19, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants