-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
410 open in side panel #10363
Merged
Merged
410 open in side panel #10363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR adds functionality to control how records are opened (in a side panel or record page) through a new openRecordIn
column in the view entity, with workflow objects defaulting to record page view.
- Added
ViewOpenRecordInType
enum andopenRecordIn
field to view entity, defaulting toSIDE_PANEL
for most objects - Implemented view settings dropdown UI with "Open in" option to toggle between side panel and record page modes
- Added migration script
UpdateDefaultViewRecordOpeningOnWorkflowObjectsCommand
to set workflow objects toRECORD_PAGE
by default - Fixed command menu animation issues by splitting close functionality into two parts: initial close and post-animation cleanup
- Removed hardcoded workflow object show page redirection in favor of configurable view-level settings
38 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/object-record/components/RecordChip.tsx
Show resolved
Hide resolved
.../upgrade-version/0-43/0-43-update-default-view-record-opening-on-workflow-objects.command.ts
Show resolved
Hide resolved
...rc/engine/workspace-manager/standard-objects-prefill-data/types/view-definition.interface.ts
Show resolved
Hide resolved
packages/twenty-server/src/modules/view/standard-objects/view.workspace-entity.ts
Show resolved
Hide resolved
thomtrp
approved these changes
Feb 20, 2025
...record/object-options-dropdown/components/ObjectOptionsDropdownViewSettingsOpenInContent.tsx
Outdated
Show resolved
Hide resolved
.../upgrade-version/0-43/0-43-update-default-view-record-opening-on-workflow-objects.command.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes twentyhq/core-team-issues#410
openRecordIn
column in theview
entity, which is set toSIDE_PANEL
by defaultopenRecordIn
workflow
,workflowVersion
andworkflowRun
(what I call workflow objects), we want the default viewopenRecordIn
to be set toRECORD_PAGE
. When seeding the views for the new workspaces, we setopenRecordIn
toRECORD_PAGE
for workflow objects. Since the workflow objects viewsopenRecordIn
will be set to the default valueSIDE_PANEL
for the existing workspaces when the sync metadata runs, I created a script to run in the 0.43 update to update this value.closeCommandMenu
because of problems introduced by the animate presence wrapper around the command menu. We now reset the states at the end of the animation.Note: We want to be able to open all workflow objects pages in the side panel, but this requires some refactoring of the workflow module. For now @Bonapara wanted to allow the possibility to change the
openRecordIn
setting toSIDE_PANEL
even for the workflows even if it's buggy and not ready for the moment. Since this is an experimental feature, it shouldn't cause too many problems.