Enhance ActiveWorkspaceCommand to order, limit and startFrom workspaceId #10378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the ActiveWorkspaceCommand with pagination and ordering capabilities, while improving error handling for workspace migrations.
- Added
startFromWorkspaceIdoption inactive-workspaces.command.tsto process workspaces starting from a specific ID - Added
workspaceCountLimitoption inactive-workspaces.command.tsto limit the number of processed workspaces - Changed workspace ordering to use
idinstead ofcreatedAtinactive-workspaces.command.tsfor consistent pagination - Improved error resilience in
0-42-migrate-rich-text-field.command.tsby handling failures per workspace instead of stopping entire migration - Ensured proper cleanup of data sources by moving
destroyDataSourceForWorkspaceoutside try-catch block
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| 'Limit the number of workspaces to process. Workspaces are processed in ascending order of id.', | ||
| required: false, | ||
| }) | ||
| parseWorkspaceCountLimit(val: number): number { |
There was a problem hiding this comment.
logic: val parameter should be typed as string since CLI inputs are strings by default. Need to convert to number internally.
Suggested change
| parseWorkspaceCountLimit(val: number): number { | |
| parseWorkspaceCountLimit(val: string): number { |
Weiko
approved these changes
Feb 21, 2025
prastoin
approved these changes
Feb 21, 2025
| 'Start from a specific workspace id. Workspaces are processed in ascending order of id.', | ||
| required: false, | ||
| }) | ||
| parseStartFromWorkspaceId(val: string): string { |
There was a problem hiding this comment.
NItpick: Unless I'm mistaken should be optional
| required: false, | ||
| }) | ||
| parseWorkspaceCountLimit(val: number): number { | ||
| this.workspaceCountLimit = val; |
There was a problem hiding this comment.
Nitpick: Unless I'm mistaken should validate is > 0 and should be optional
Unless I'm mistaken this might not be an issue as if a new workspace is created it should already be migrated by definition |
prastoin
pushed a commit
that referenced
this pull request
Feb 21, 2025
…eId (#10378) I have tested it locally with all combinaisons of params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested it locally with all combinaisons of params