cleaning workspace job - fix on soft delete condition #10380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds a condition to prevent re-processing of soft-deleted workspaces in the workspace cleaning service, preventing duplicate deletion emails from being sent to workspace members.
- Added
!isDefined(workspace.deletedAt)check in/packages/twenty-server/src/engine/workspace-manager/workspace-cleaner/services/cleaner.workspace-service.tsto prevent re-processing soft-deleted workspaces - Ensures workspace members only receive deletion notification emails once when their workspace is initially soft-deleted
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
etiennejouan
changed the title
Weiko
approved these changes
Feb 21, 2025
charlesBochet
approved these changes
Feb 21, 2025
|
Thanks @etiennejouan for your contribution! |
charlesBochet
pushed a commit
that referenced
this pull request
Feb 21, 2025
Context If the command runs multiple times, soft deleted workspaces are soft deleted again (+ email spamming) Solution Check for soft deletion before entering soft delete condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
If the command runs multiple times, soft deleted workspaces are soft deleted again (+ email spamming)
Solution
Check for soft deletion before entering soft delete condition