-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix open record in setting for command menu v1 #10383
Conversation
bosiraphael
commented
Feb 21, 2025
- Hide open record in settings for command menu version 1 users
- Create a selector to check which version of the command menu the user has before returning if the record should be opened in the record page or in the side panel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR implements a feature flag-based control for record opening behavior, ensuring backward compatibility between command menu versions.
- Added new
recordIndexOpenRecordInSelector
to enforce record page view for command menu v1 users while allowing v2 users to choose between record page and side panel - Conditionally hides "Open in" menu item in view settings dropdown when command menu v2 is disabled
- Modified record opening logic across multiple components (RecordChip, ChipFieldDisplay, RecordBoardCardHeader) to use the new selector
- Ensures view settings menu item only appears for Kanban views or when command menu v2 is enabled
- Maintains consistent behavior by checking
IsCommandMenuV2Enabled
feature flag throughout the codebase
7 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
/> | ||
</DropdownMenuItemsContainer> | ||
<DropdownMenuSeparator /> | ||
{(isCommandMenuV2Enabled || viewType === ViewType.Kanban) && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: From my understanding user might have access to a featureFlag gated feature if he's on a KANBAN view despite flag status ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The compact view setting is still accessible inside view settings on the kanban so we want to be able to navigate to it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The open record in setting won't be accessible on the kanban, only the compact view mode
...t/src/modules/object-record/record-index/states/selectors/recordIndexOpenRecordInSelector.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.