[permissions] Rename enum SettingsFeatures --> SettingsPermissions #10389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR renames the SettingsFeatures enum to SettingsPermissions across the entire codebase to better reflect its purpose in managing permissions rather than features.
Key changes:
- Renamed enum in
packages/twenty-shared/src/constants/SettingsPermissions.tswhile preserving all enum values - Updated import statements and type annotations in both frontend and backend files
- Modified GraphQL schema definitions to use the new enum name in generated types
- Updated test files to maintain consistency with the renamed enum
- Adjusted guard decorators across resolvers to use the renamed enum for permission checks
The changes improve naming clarity and semantic accuracy without modifying any underlying functionality or permission values.
31 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
122
to
124
| const permittedFeatures: SettingsPermissions[] = ( | ||
| Object.keys(settingsPermissions) as SettingsPermissions[] | ||
| ).filter((feature) => settingsPermissions[feature] === true); |
There was a problem hiding this comment.
style: Variable name 'permittedFeatures' should be renamed to 'permittedPermissions' to match the new enum name
There was a problem hiding this comment.
will update that in my next pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.