Fix error messages on sign up #10399
Conversation
| @@ -63,11 +63,19 @@ export class WorkspaceManagerService { | |||
| workspaceId: string; | |||
| userId: string; | |||
| }): Promise<void> { | |||
| const schemaCreationStart = performance.now(); | |||
There was a problem hiding this comment.
Temporarily adding these logs to troubleshoot prod performance on workspace creation (~15s in prod) and see what optimizations we can do while keeping 2k5 workspaces on prod
There was a problem hiding this comment.
I think there is a decorator for that
There was a problem hiding this comment.
Ah never mind, you don't want log for the whole function
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors workspace activation status checks across the frontend codebase, introducing performance monitoring on the backend. Here's a concise summary of the key changes:
- Introduced new
useIsWorkspaceActivationStatusEqualsTohook in/packages/twenty-front/src/modules/workspace/hooks/useIsWorkspaceActivationStatusEqualsTo.tsfor flexible workspace status checks - Replaced
useIsWorkspaceActivationStatusSuspendedwith the new hook across multiple components for more consistent status checking - Added performance logging in
/packages/twenty-server/src/engine/workspace-manager/workspace-manager.service.tsto measure workspace initialization steps - Added detailed timing metrics in
/packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/workspace-sync-metadata.service.tsfor metadata sync operations - Changed workspace status checks from negative (suspended) to positive (active) conditions in prefetch components for better readability
The changes improve code maintainability while adding valuable performance insights for debugging and monitoring.
11 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| `Metadata creation took ${dataSourceMetadataCreationEnd - dataSourceMetadataCreationStart}ms`, | ||
| ); | ||
|
|
||
| const permissionsEnabledStart = performance.now(); | ||
| const permissionsEnabled = | ||
| await this.permissionsService.isPermissionsEnabled(); |
There was a problem hiding this comment.
style: Explicit boolean comparison with === true is redundant
| await this.permissionsService.isPermissionsEnabled(); | |
| if (permissionsEnabled) { |
| this.logger.log( | ||
| `Workspace object migrations took ${workspaceObjectMigrationsEnd - workspaceObjectMigrationsStart}ms`, | ||
| ); |
There was a problem hiding this comment.
style: use this.logger.log() instead of console.log() for consistent logging and production environments
In this PR: