Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lambda iam #11163

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Fix lambda iam #11163

merged 2 commits into from
Mar 25, 2025

Conversation

martmull
Copy link
Contributor

As title, fix lambda driver for serverless functions

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Improved security and configurability of Lambda driver implementation for serverless functions by modifying credential handling and role management.

  • Reduced credential duration from 10 hours to 1 hour in packages/twenty-server/src/engine/core-modules/serverless/drivers/lambda.driver.ts for enhanced security
  • Added configurable subhostingRole option in LambdaDriverOptions interface to replace hardcoded role ARN
  • Implemented credential expiry check and refresh mechanism in getLambdaClient() method
  • Added robust error handling for missing credentials in getAssumeRoleCredentials()

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@martmull martmull merged commit 45b8a33 into main Mar 25, 2025
32 checks passed
@martmull martmull deleted the fix-lambda-iam branch March 25, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants