Fix:Empty link in record details isn't deleted by default #9840
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds functionality to handle empty link deletion in record details, ensuring that empty links are properly removed when a user clears the input field.
- Added
isClearingInputstate inMultiItemFieldInput.tsxto track input clearing status - Modified
handleSubmitInputto trigger item deletion when input is cleared - Improved empty string validation using
turnIntoEmptyStringIfWhitespacesOnlyutility - Integrated with existing link field components to maintain consistent behavior
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| if (value === '' && itemToEditIndex !== null) { | ||
| setIsClearingInput(true); |
There was a problem hiding this comment.
logic: comparing with !== null here is incorrect since itemToEditIndex is a number. Should use !== -1 to match initialization
| if (isClearingInput && itemToEditIndex !== null) { | ||
| handleDeleteItem(itemToEditIndex); |
There was a problem hiding this comment.
logic: same issue here with !== null comparison for itemToEditIndex
There was a problem hiding this comment.
Hi @Lucifer4255, thank you for your PR.
Your solution is not handling case where input is empty string (without update).
I would handle empty string input in handleSubmitInput method.
- If inputValue is empty string AND isAddingNewItem, it should early return
- If inputValue is empty string AND !isAddingNewItem, it should delete updated item and early return
Lucifer4255
force-pushed
the
empty_link_fix
branch
from
6c7d889 to
bdc6481
Compare
There was a problem hiding this comment.
@Lucifer4255 thank you for your update, added few comments.
| @@ -69,6 +69,7 @@ export const MultiItemFieldInput = <T,>({ | |||
|
|
|||
| useScopedHotkeys(Key.Escape, handleDropdownClose, hotkeyScope); | |||
|
|
|||
| const [isClearingInput, setIsClearingInput] = useState(false); | |||
There was a problem hiding this comment.
You can remove this state. Empty input case is handled at submit.
| if (isClearingInput && itemToEditIndex !== -1) { | ||
| handleDeleteItem(itemToEditIndex); | ||
| return; | ||
| } |
There was a problem hiding this comment.
same here, you can delete these lines. no need to handle empty item deletion since they're not created anymore thanks to logic above.
| if (value === '' && itemToEditIndex !== -1) { | ||
| setIsClearingInput(true); | ||
| } else { | ||
| setIsClearingInput(false); | ||
| } | ||
|
|
There was a problem hiding this comment.
same here, you can remove these lines
Gives a fix for #9780 . I have added handleDelete inside the submit function and created a state to manage the empty placeholder
Screencast from 2025-01-24 01-45-22.webm