chore: not extending html props from paste types

.changeset/tender-parrots-look.md

@@ -0,0 +1,6 @@
+---
+"@twilio-paste/table": patch
+"@twilio-paste/core": patch
+---
+
+[Table] Improved TsDoc type annotations

package.json

@@ -6,7 +6,12 @@
   "author": "Twilio Inc.",
   "license": "MIT",
   "workspaces": {
-    "packages": ["apps/**/*", "packages/**/*", "templates/**/*", "!packages/paste-core/core-bundle/**/*"]
+    "packages": [
+      "apps/**/*",
+      "packages/**/*",
+      "templates/**/*",
+      "!packages/paste-core/core-bundle/**/*"
+    ]
   },
   "types": "./types/index.d.ts",
   "engines": {
@@ -222,5 +227,9 @@
     }
   },
   "packageManager": "[email protected]",
-  "browserslist": ["last 2 versions", "not dead", "not IE 11"]
+  "browserslist": [
+    "last 2 versions",
+    "not dead",
+    "not IE 11"
+  ]
 }

packages/paste-core/components/data-grid/src/DataGridCell.tsx

@@ -8,19 +8,12 @@ import { DataGridContext } from "./DataGridContext";
 import { Td } from "./table/Td";
 import type { TdProps } from "./table/Td";
 import { Th } from "./table/Th";
+import type { ThProps } from "./table/Th";
 import { ensureFocus, isCell, updateTabIndexForActionable } from "./utils";
 
 // This module can only be referenced with ECMAScript imports/exports by turning on the 'esModuleInterop' flag and referencing its default export
 
-type CellType = "th" | "td";
-export interface DataGridCellProps extends Pick<TdProps, "textAlign"> {
-  /**
-   * Cells can either be th or td, so rows can have headers.
-   *
-   * @type {CellType}
-   * @memberof DataGridCellProps
-   */
-  as?: CellType;
+export type DataGridCellBasePropsProps = {
   /**
    * Overrides the default element name to apply unique styles with the Customization Provider
    *
@@ -36,7 +29,17 @@ export interface DataGridCellProps extends Pick<TdProps, "textAlign"> {
    * @memberof DataGridCellProps
    */
   colSpan?: number;
-}
+};
+type DataGridCellAsThProps = ThProps &
+  DataGridCellBasePropsProps & {
+    as?: "th";
+  };
+type DataGridCellAsTdProps = TdProps &
+  DataGridCellBasePropsProps & {
+    as?: "td";
+  };
+
+export type DataGridCellProps = DataGridCellAsThProps | DataGridCellAsTdProps;
 
 /**
  * DataGrid cell component. Every visible box in a data grid is powered by the cell.

packages/paste-core/components/data-grid/src/DataGridHeaderSort.tsx

@@ -1,9 +1,11 @@
 import type { BoxProps } from "@twilio-paste/box";
 import { Button } from "@twilio-paste/button";
+import type { ButtonProps } from "@twilio-paste/button";
 import { ArrowDownIcon } from "@twilio-paste/icons/esm/ArrowDownIcon";
 import { ArrowUpIcon } from "@twilio-paste/icons/esm/ArrowUpIcon";
 import { UnsortedIcon } from "@twilio-paste/icons/esm/UnsortedIcon";
 import { ScreenReaderOnly } from "@twilio-paste/screen-reader-only";
+import type { HTMLPasteProps } from "@twilio-paste/types";
 import * as React from "react";
 
 export type SortDirection = "ascending" | "descending" | "none";
@@ -37,7 +39,7 @@ const DataGridHeaderSortIcon: React.FC<React.PropsWithChildren<DataGridHeaderSor
 
 DataGridHeaderSortIcon.displayName = "DataGridHeaderSortIcon";
 
-export interface DataGridHeaderSortProps extends DataGridHeaderSortIconProps {
+export interface DataGridHeaderSortProps extends HTMLPasteProps<"button">, DataGridHeaderSortIconProps {
   /**
    * Overrides the default element name to apply unique styles with the Customization Provider
    *
@@ -76,6 +78,7 @@ export interface DataGridHeaderSortProps extends DataGridHeaderSortIconProps {
    * @memberof DataGridHeaderSortProps
    */
   i18nUnsortedLabel?: string;
+  tabIndex?: ButtonProps["tabIndex"];
 }
 
 /**

packages/paste-core/components/data-grid/src/DataGridRow.tsx

@@ -4,8 +4,9 @@ import * as React from "react";
 
 import { DataGridContext } from "./DataGridContext";
 import { Tr } from "./table/Tr";
+import type { TrProps } from "./table/Tr";
 
-export interface DataGridRowProps {
+export interface DataGridRowProps extends TrProps {
   children: NonNullable<React.ReactNode>;
   /**
    * Visally displays a row highlight indicating selection and sets `aria-selected`