chore: ignore generated storybook docs from format and format generated core bundle files #3512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed core bundle files
|
|
|
github-actions
bot
added
the
Status: Do Not Merge
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 81aef4d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 81aef4d:
|
|
Size Change: 0 B Total Size: 1 MB ℹ️ View Unchanged
|
Passing run #6909 ↗︎
Details:
Review all test suite changes for PR #3512 ↗︎ |
|||||||||||||||
nkrantz
previously approved these changes
Oct 2, 2023
TheSisb
reviewed
Oct 2, 2023
| @@ -25,7 +25,8 @@ | |||
| "**/*.d.ts", | |||
| ".codesandbox/ci.json", | |||
| "build.icon-list.js", | |||
| "**/*.hbs" | |||
| "**/*.hbs", | |||
| "docs" | |||
There was a problem hiding this comment.
praise: good catch. debugged this separately in nora's branch too. Sorry for the miss here
TheSisb
previously approved these changes
Oct 2, 2023
SiTaggart
added
🚀 merge it!
🕵🏻♀️ Run website visual regression
github-actions
bot
added
the
Area: Infrastructure
nkrantz
approved these changes
Oct 3, 2023
TheSisb
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and useful links to discussions / issues / tickets
Changes in this PR:
Ignore storybook build
Formatter tries to format compiled storybook source
Generate core files correctly formatted
If you build core, it'll tell you the generated files are incorrect.
Checklist
requiredchecks have passed🕵🏻♀️ Run website visual regressionlabel