feat: updated site search #3534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Type: Documentation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 307ff15. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 307ff15:
|
|
Size Change: 0 B Total Size: 1 MB ℹ️ View Unchanged
|
github-actions
bot
added
the
Area: Infrastructure
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Passing run #7016 ↗︎
Details:
Review all test suite changes for PR #3534 ↗︎ |
|||||||||||||||
SiTaggart
force-pushed
the
feat/updated-site-search
branch
from
24779e5 to
43bca5d
Compare
github-actions
bot
added
Type: Tests
SiTaggart
force-pushed
the
feat/updated-site-search
branch
from
43bca5d to
8c83ee9
Compare
TheSisb
reviewed
Oct 13, 2023
| cy.get(".DocSearch-Hits").should("have.length.above", 0); | ||
| cy.get('.DocSearch-Hits [role="listbox"]').should("have.length.above", 0); | ||
| cy.get('.DocSearch-Hits [role="option"]').should("have.length.above", 0); | ||
| cy.get('[data-cy="paste-docsearch-hits"] h2').should("have.length.above", 0); |
There was a problem hiding this comment.
praise: it's great we can reuse this file!
packages/paste-website/src/components/site-search/SearchEmptyIllustration.tsx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/components/site-search/SearchResultDocs.tsx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/components/site-search/SearchResults.tsx
Outdated
Show resolved
Hide resolved
SiTaggart
force-pushed
the
feat/updated-site-search
branch
from
27356a1 to
31da305
Compare
Co-authored-by: TheSisb <[email protected]>
|
Not blockers but let's call them "known issues"
Screen.Recording.2023-10-16.at.10.56.03.AM.mov |
serifluous
previously approved these changes
Oct 16, 2023
SiTaggart
added
🚀 merge it!
🕵🏻♀️ Run website visual regression
TheSisb
previously approved these changes
Oct 17, 2023
nkrantz
previously approved these changes
Oct 17, 2023
serifluous
previously approved these changes
Oct 17, 2023
SiTaggart
dismissed stale reviews from serifluous, nkrantz, and TheSisb
via
6ae0c62
serifluous
approved these changes
Oct 17, 2023
TheSisb
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and useful links to discussions / issues / tickets
Changes in this PR:
Updated site search
Replace Algolia for our own vector based search across all our doc pages and github discussions.
Checklist
requiredchecks have passed🕵🏻♀️ Run website visual regressionlabel