Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the select changeset to better reflect the updated change #3563

Merged
merged 1 commit into from
Oct 18, 2023
+2 −2
Merged

chore: update the select changeset to better reflect the updated change #3563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .changeset/thirty-forks-poke.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@

Since the React v18 upgrade, we were only rendering the children options after the component and html select
wrapper had mounted. The select would mount with a `defaultValue` of a child that didn't exist, then the
children would be added, so it wouldn't know what value to select. By adding a `key` prop to the select,
it now knows to re-render on mount with the children, and can properly lookup the correct value now.
children would be added, so it wouldn't know what value to select. To fix the hydration and `defaultValue`
together we now re-render the entire Select on mount.
Loading