chore: yarn v4 #3583
Closed
chore: yarn v4 #3583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
github-actions
bot
added
the
Status: Do Not Merge
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
Area: Infrastructure
SiTaggart
commented
Oct 28, 2023
| @@ -222,6 +222,7 @@ | |||
| }, | |||
| "resolutions": { | |||
| "csstype": "3.0.11", | |||
| "meow": "8.1.2", | |||
There was a problem hiding this comment.
yarn v4 has a much stricter resolution check on PRs and the lockfile seemed to have a v6 of meow listed which caused install to break. Resolving the whole monorepo to the codemod version fixed it
SiTaggart
commented
Oct 28, 2023
| @@ -34,9 +34,9 @@ jobs: | |||
| id: yarn_cache_id | |||
| with: | |||
| path: ${{ steps.yarn-cache-dir-path.outputs.dir }} | |||
| key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} | |||
| key: ${{ runner.os }}-yarn-4-${{ hashFiles('**/yarn.lock') }} | |||
There was a problem hiding this comment.
I'm just busting the yarn cache in github actions to make sure it is full tested
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d1243af. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
SiTaggart
commented
Oct 28, 2023
.codesandbox/ci.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "buildCommand": "build", | |||
| "node": "16", | |||
| "node": "20", | |||
There was a problem hiding this comment.
Yarn v4 required node 18+. We run 20
|
Size Change: 0 B Total Size: 1 MB ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d1243af:
|
Passing run #7079 ↗︎
Details:
Review all test suite changes for PR #3583 ↗︎ |
|||||||||||||||
|
More effort that I am willing to invest in right now. I'd rather move to pnpm if I need to actually do work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and useful links to discussions / issues / tickets
Changes in this PR:
Change One
Details of change...
Change Two
Details of change...
Checklist
requiredchecks have passed🕵🏻♀️ Run website visual regressionlabel