-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ability to post slack upates #3744
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Run & review this pull request in StackBlitz Codeflow. |
|
Size Change: 0 B Total Size: 1.01 MB ℹ️ View Unchanged
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c8e21ee:
|
Passing run #7602 ↗︎
Details:
Review all test suite changes for PR #3744 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!!!
const latestSearchQueriesResponse = await supabaseClient.rpc("match_weekly_search_usage"); | ||
|
||
if (latestSearchQueriesResponse.error) { | ||
logger.error(`${LOG_PREFIX} Error fetching latest search queries`, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: I almost wish logger.error also called rollbar.error internally. Would remove a lot of this duplication code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's just a instantiation of a winston logger, we might be able to create a custom transporter that calls rollbar on error maybe? No sure if that's its intended purpose though.
Passing run #7610 ↗︎
Details:
Review all test suite changes for PR #3744 ↗︎ |
Description and useful links to discussions / issues / tickets
Changes in this PR:
Endpoint to post to slack
Simple API route to post an update to a Slack channel
Endpoint to post docsite search usage to Slack
Via a vercel cron job that will run once a week and post the usage of the docsite search to a slack channel
Checklist
required
checks have passed🕵🏻♀️ Run website visual regression
label