Pill large dismiss #4003
Merged
Pill large dismiss #4003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 4cc2bed The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
the
Area: Components
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4cc2bed. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4cc2bed:
|
|
Size Change: +37 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
Passing run #8341 ↗︎
Details:
Review all test suite changes for PR #4003 ↗︎ |
|||||||||||||||
dosubot
bot
added
the
size:S
nkrantz
reviewed
Jul 26, 2024
nkrantz
reviewed
Jul 26, 2024
Co-authored-by: Nora Krantz <[email protected]>
krisantrobus
previously approved these changes
Jul 26, 2024
roxanagomez
reviewed
Jul 26, 2024
| height="sizeIcon40" | ||
| width="sizeIcon40" | ||
| height={size === "large" ? "sizeIcon50" : "sizeIcon40"} | ||
| width={size === "large" ? "sizeIcon50" : "sizeIcon40"} |
There was a problem hiding this comment.
issue: PillCloseIcon for the large variant should be slightly bigger. Currently, both variants seem to be the same size.
Figma screenshot
Design sizes:
Default (PillCloseIcon): size-icon-10
Large (PillCloseIcon): size-icon-20
There was a problem hiding this comment.
Note: Not sure why the sizes are different in the code :'( is that expected? or am I checking in the wrong place?
There was a problem hiding this comment.
It's on line 63 of this file 🤓 I'll bump it up to sizeIcon20
dosubot
bot
removed
the
size:S
dosubot
bot
added
the
size:M
roxanagomez
approved these changes
Jul 26, 2024
nkrantz
approved these changes
Jul 26, 2024
nkrantz
added
🚀 merge it!
🕵🏻♀️ Run website visual regression
Passing run #8343 ↗︎
Details:
Review all test suite changes for PR #4003 ↗︎ |
|||||||||||||||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dismiss button position for large pill size