feat(popover): add form pill button #4018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: e3ff42a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Area: Components
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e3ff42a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e3ff42a:
|
|
Size Change: +187 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
github-actions
bot
added
Type: Documentation
krisantrobus
reviewed
Aug 5, 2024
| @@ -298,6 +308,27 @@ To launch a Popover from a Badge component, use the PopoverBadgeButton component | |||
| {badgeExample} | |||
| </LivePreview> | |||
|
|
|||
| ### PopoverFormPillButton | |||
|
|
|||
| This component is to **only be used as part of the Filters pattern**. It renders a FormPill and accepts all of its props, which are listed [on the FormPillGroup page](/components/form-pill-group#basic). | |||
There was a problem hiding this comment.
Filters pattern will need to be updated with link once live
dosubot
bot
added
the
size:XL
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
serifluous
previously approved these changes
Aug 5, 2024
nkrantz
commented
Aug 13, 2024
nkrantz
commented
Aug 13, 2024
serifluous
reviewed
Aug 13, 2024
packages/paste-website/src/component-examples/PopoverExamples.ts
Outdated
Show resolved
Hide resolved
serifluous
previously approved these changes
Aug 13, 2024
krisantrobus
added
the
🕵🏻♀️ Run website visual regression
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
krisantrobus
approved these changes
Aug 13, 2024
krisantrobus
added
🚀 merge it!
and removed
Status: Do Not Merge
serifluous
approved these changes
Aug 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio