chore: add pattern exploration jira template #4079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
serifluous
commented
Sep 17, 2024
•
serifluous
commented
- Fixes broken link and image in Contribution readme.
- Adds a jira template for pattern explorations
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
github-actions
bot
added
the
Status: Do Not Merge
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 04937d8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
Size Change: 0 B Total Size: 1.09 MB ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 04937d8:
|
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
chore-pattern-exploration-jira
|
| Run status |
|
| Run duration | 02m 00s |
| Commit |
|
| Committer | kodiakhq[bot] |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
67
|
| View all changes introduced in this branch ↗︎ | |
dosubot
bot
added
the
size:S
serifluous
requested review from
a team,
krisantrobus,
PixeledCode and
nkrantz
and removed request for
a team and
krisantrobus
nkrantz
reviewed
Sep 18, 2024
|
|
||
| _If the design is straightforward and/or has limited interactions, this can be closed as “won’t do”._ | ||
|
|
||
| - Build prototypes in Storybook to make sure components in the pattern work together so we can check accessibility early. Base these prototypes on the most varied iterations Design currently has (choose < 3) to help check for feasability and uncover any usability issues. |
nkrantz
approved these changes
Sep 18, 2024
PixeledCode
approved these changes
Sep 19, 2024
PixeledCode
added
🚀 merge it!
and removed
Status: Do Not Merge
serifluous
added
the
🕵🏻♀️ Run website visual regression
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
chore-pattern-exploration-jira
|
| Run status |
|
| Run duration | 06m 05s |
| Commit |
|
| Committer | Sarah |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.