fix(nav): docs site navigation #4083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
PixeledCode
commented
Sep 20, 2024
PixeledCode
commented
- fixed horizontal scroll on mobile nav
- Change Paste logo to the default logo
|
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PixeledCode
force-pushed
the
fix-nav-mobile
branch
from
959db2c to
5990d2c
Compare
github-actions
bot
added
Status: Do Not Merge
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5761553. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
Size Change: 0 B Total Size: 1.09 MB ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5761553:
|
dosubot
bot
added
the
size:M
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
fix-nav-mobile
|
| Run status |
|
| Run duration | 02m 04s |
| Commit |
|
| Committer | Shoaib Ahmed |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
67
|
| View all changes introduced in this branch ↗︎ | |
roxanagomez
reviewed
Sep 24, 2024
| @@ -1,14 +1,12 @@ | |||
| import { Box } from "@twilio-paste/box"; | |||
| import { LogoPasteIcon } from "@twilio-paste/icons/esm/LogoPasteIcon"; | |||
There was a problem hiding this comment.
issue: The logo without background is not working for light mode, maybe we should use the red background version, so it works in both dark and light mode.
| import * as React from "react"; | ||
| import { useHotkeys } from "react-hotkeys-hook"; | ||
|
|
||
| import { SiteSearch } from "../../site-search"; | ||
|
|
||
| const SiteHeaderSearch: React.FC = () => { | ||
| const [isOpen, setIsOpen] = React.useState(false); | ||
| const { breakpointIndex } = useWindowSize(); |
There was a problem hiding this comment.
question: Do you know if we have a minimum window size we optimize for? I'm testing at 320px and it breaks, I was only able to test on this screen size in the browser, in my mobile device is working well, and the issue is fixed.
There was a problem hiding this comment.
yeah so with current implementation, 340px is the lower limit
roxanagomez
approved these changes
Sep 26, 2024
PixeledCode
added
the
🕵🏻♀️ Run website visual regression
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
fix-nav-mobile
|
| Run status |
|
| Run duration | 06m 33s |
| Commit |
|
| Committer | Shoaib Ahmed |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
krisantrobus
approved these changes
Sep 26, 2024
PixeledCode
added
🚀 merge it!
and removed
Status: Do Not Merge
PixeledCode
force-pushed
the
fix-nav-mobile
branch
from
e7c1fb4 to
5761553
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.