Update ai chat #4331
Merged
Update ai chat #4331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
🦋 Changeset detectedLatest commit: 4021ac8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
Area: Components
|
View your CI Pipeline Execution ↗ for commit 4021ac8.
☁️ Nx Cloud last updated this comment at |
|
Size Change: +528 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4021ac8:
|
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
update-ai-chat
|
| Run status |
|
| Run duration | 04m 16s |
| Commit |
|
| Committer | kodiakhq[bot] |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
69
|
| View all changes introduced in this branch ↗︎ | |
dosubot
bot
added
the
size:XXL
|
TODO: The bottom padding on the chat bubbles is larger than the top. Could we make them match? I imagine is because of the date boolean. btw I had the same issue in Figma, so I created a frame around the message and added a bottom margin so that when timestamp = false, the padding remains consistent, in case that is of any use. |
|
Nitpick: In the 'AI chat log with timestamp' example can we please include the date event. |
|
Suggestion/nitpick: I think for the chat event specially in the Fullscreen variant we're going to need to have more padding for the events so they don't get lost in the conversation, could we try adding space-50 as top and bottom margin to the event element and see how it looks? |
|
TODO: I didn't specify this on the spec but, the error variant for user message should have the action card outside the bubble. 
|
|
nitpick: Can we set the top padding of the timestamp in bot messages to space-30 for both Fullscreen and Default variants? |
Comment on lines
+76
to
+86
| const StyledBox = styled(Box)( | ||
| css({ | ||
| "& p:first-of-type": { | ||
| marginTop: "0", | ||
| }, | ||
| "& p:last-of-type": { | ||
| marginBottom: "0", | ||
| }, | ||
| }), | ||
| ); | ||
|
|
There was a problem hiding this comment.
praise: I'm happy with this fix. A great solution to target elements 🎉
Comment on lines
-269
to
-271
| <AIChatMessageAuthor aria-label="You said at 2:36pm" avatarName="Gibby Ridki"> | ||
| You | ||
| </AIChatMessageAuthor> |
There was a problem hiding this comment.
question (non-blocking): is there a reason for removing the author from so many stories?
There was a problem hiding this comment.
yes, as per designs we are not recommending Author for users
github-actions
bot
added
Type: Documentation
roxanagomez
approved these changes
Jun 3, 2025
PixeledCode
added
🚀 merge it!
🕵🏻♀️ Run website visual regression
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
update-ai-chat
|
| Run status |
|
| Run duration | 07m 35s |
| Commit |
|
| Committer | Shoaib Ahmed |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://paste-docs-git-update-ai-chat-twilio.vercel.app/components/ai-chat-log