Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update track switch off UI #731

Closed
wants to merge 5 commits into from
Closed

Conversation

olipyskoty
Copy link
Contributor

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR is a copy of PR #708. This branch has been created off of main in order to avoid a large and confusing merge conflict (merging main into old VIDEO-9513-update-disabled-video-ui branch).

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@olipyskoty olipyskoty requested a review from timmydoza July 13, 2022 18:09
@olipyskoty olipyskoty mentioned this pull request Jul 13, 2022
10 tasks
Comment on lines 216 to 222
{isVideoSwitchedOff && (
<div className={clsx(classes.trackSwitchOffContainer, { [classes.isSwitchedOff]: isVideoSwitchedOff })}>
<Typography variant="body1" className={classes.switchedOffMessage}>
Video has been switched off to conserve bandwidth.
</Typography>
</div>
)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{isVideoSwitchedOff && (
<div className={clsx(classes.trackSwitchOffContainer, { [classes.isSwitchedOff]: isVideoSwitchedOff })}>
<Typography variant="body1" className={classes.switchedOffMessage}>
Video has been switched off to conserve bandwidth.
</Typography>
</div>
)}
<div className={clsx(classes.trackSwitchOffContainer, { [classes.isSwitchedOff]: isVideoSwitchedOff })}>
<Typography variant="body1" className={classes.switchedOffMessage}>
Video has been switched off to conserve bandwidth.
</Typography>
</div>

We don't need the isVideoSwitchedOff && since the visibility is determined by the isSwitchedOff class. Plus, when we remove this element from the page when video is switched on, it prevents us from seeing the fade-out of the text.

@olipyskoty olipyskoty requested a review from timmydoza July 14, 2022 19:20
@olipyskoty olipyskoty mentioned this pull request Aug 30, 2022
10 tasks
@olipyskoty
Copy link
Contributor Author

Closing - opened new PR for new designs in #745

@olipyskoty olipyskoty closed this Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants