-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update track switch off UI #731
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
timmydoza
suggested changes
Jul 14, 2022
Comment on lines
216
to
222
{isVideoSwitchedOff && ( | ||
<div className={clsx(classes.trackSwitchOffContainer, { [classes.isSwitchedOff]: isVideoSwitchedOff })}> | ||
<Typography variant="body1" className={classes.switchedOffMessage}> | ||
Video has been switched off to conserve bandwidth. | ||
</Typography> | ||
</div> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
{isVideoSwitchedOff && ( | |
<div className={clsx(classes.trackSwitchOffContainer, { [classes.isSwitchedOff]: isVideoSwitchedOff })}> | |
<Typography variant="body1" className={classes.switchedOffMessage}> | |
Video has been switched off to conserve bandwidth. | |
</Typography> | |
</div> | |
)} | |
<div className={clsx(classes.trackSwitchOffContainer, { [classes.isSwitchedOff]: isVideoSwitchedOff })}> | |
<Typography variant="body1" className={classes.switchedOffMessage}> | |
Video has been switched off to conserve bandwidth. | |
</Typography> | |
</div> |
We don't need the isVideoSwitchedOff &&
since the visibility is determined by the isSwitchedOff class. Plus, when we remove this element from the page when video is switched on, it prevents us from seeing the fade-out of the text.
10 tasks
Closing - opened new PR for new designs in #745 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
This PR is a copy of PR #708. This branch has been created off of
main
in order to avoid a large and confusing merge conflict (mergingmain
into oldVIDEO-9513-update-disabled-video-ui
branch).Burndown
Before review
npm test
Before merge