Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds path stripping to Azure Blob destination, adds hostname to MySQLConfig #467

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

Jsalz2000
Copy link
Contributor

This pull request includes a version update for TwinDB Backup from 3.3.0 to 3.4.0, along with several other enhancements and fixes. The most important changes include updating version references, adding a new hostname configuration option for MySQL, and improving the handling of remote paths in Azure Blob Storage.

Version Update:

  • Updated version references from 3.3.0 to 3.4.0 in README.rst, docs/installation.rst, omnibus/config/projects/twindb-backup.rb, setup.cfg, setup.py, and twindb_backup/__init__.py. [1] [2] [3] [4] [5] [6] [7]

MySQL Configuration Enhancements:

  • Added hostname option to MySQL configuration with a default value of 127.0.0.1 in docs/usage.rst, support/twindb-backup.cfg, twindb_backup/configuration/mysql.py, and vagrant/environment/puppet/modules/profile/files/twindb-backup.cfg. [1] [2] [3] [4] [5]
  • Updated backup_mysql and backup_binlogs functions to use the new hostname configuration in twindb_backup/backup.py. [1] [2] [3] [4]

Azure Blob Storage Improvements:

  • Improved handling of remote paths by stripping slashes in twindb_backup/destination/az.py, tests/unit/destination/az/test_init.py, tests/unit/destination/az/test_list_files.py, and tests/unit/destination/az/util.py. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

Unit Tests:

  • Added unit tests for new MySQL configuration options and improved existing tests in tests/unit/configuration/test_mysql.py.
  • Added a new unit test for remote path handling in Azure Blob Storage in tests/unit/destination/az/test_list_files.py.

Miscellaneous:

  • Updated the get_stream method in twindb_backup/source/mysql_source.py to use the new hostname configuration.

@Jsalz2000
Copy link
Contributor Author

Jsalz2000 commented Oct 14, 2024

This PR plans to fix this issue [Question] Hard-Coding --host=127.0.01 in mysql_source.py · Issue #184 · twindb/backup

If you would rather split these changes into two separate PRs, please let me know.

@Jsalz2000
Copy link
Contributor Author

I would also like to discuss adding support for building on enterprise linux (in general) 7, 8 and 9. I created these branches in a personal repo that I have been building our images with. These docker images use Oracle Linux as a base, it's frequently updated and JustWorks.
el7, el8, el9

We could possibly create another repo in twindb, or look at merging with twindb/omnibus-centos

@Jsalz2000
Copy link
Contributor Author

@akuzminsky - Could I please get a review/approve for this PR?

Copy link
Contributor

@ernstae ernstae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed this code internally, and we are running this successfully against Azure Blob storage. Looking to get this merged in, and a further story on RPM and other package builds. We should consider whether there's a path forward for Oracle Linux, Rocky Linux or Alma Linux build processes to get new RPMs out into the world (or at least in the Releases artifacts of this repo).

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants