-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define new request class for general sanity #181
Conversation
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
=========================================
- Coverage 95.89% 95.6% -0.29%
=========================================
Files 12 17 +5
Lines 1558 2092 +534
Branches 86 148 +62
=========================================
+ Hits 1494 2000 +506
- Misses 52 72 +20
- Partials 12 20 +8
Continue to review full report at Codecov.
|
…ich URL is helpfully being stricter about now.
OK so the current build failure is caused by python-hyper/hyperlink#19. Need to figure out if that's something we need to avoid, or fix elsewhere. |
…git characters and go back to excluding specific characters.
IDNA encoding of DOUBLE QUESTION MARK is also annoying.
@markrwilliams: Regarding Then |
…ASCII is what the cool kids use.
OK, caught up with stricter URL checks, build is happy, and I think I've addressed all review items above. |
src/klein/_headers.py
Outdated
Note that header name bytes should be strictly encoded as ASCII; this | ||
interface uses ISO-8859-1 to provide interoperability with (naughty) HTTP | ||
implementations that send non-ASCII data. | ||
Because ISO-8859-1 is a superset if ASCII, this will still work for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if → of
Withdrawing in favor of https://github.com/wsanchez/txrequest/ |
No description provided.