Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventSub housekeeping #455

Merged
merged 4 commits into from
Nov 22, 2024
Merged

EventSub housekeeping #455

merged 4 commits into from
Nov 22, 2024

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Nov 20, 2024 •
edited
Loading

@Nerixyz
Copy link
Contributor Author

Nerixyz commented Nov 22, 2024

channel.channel_points_automatic_reward_redemption.add doesn't refer to the message. And that message explicitly mentions "The text of the resubscription chat message." So I'll make a new message type when I add the reward-event.

@Nerixyz Nerixyz marked this pull request as ready for review November 22, 2024 18:29
@Nerixyz Nerixyz requested a review from Emilgardis November 22, 2024 18:29
@Nerixyz Nerixyz added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 8b65d25 Nov 22, 2024
19 checks passed
@Nerixyz Nerixyz deleted the chore/eventsub-fix-or-mini-refactor branch November 22, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swapped display-name/login types in EventSub SubscriptionMessage shouldn't be tied to subscriptions
2 participants
@Nerixyz @Emilgardis