feat(eventsub): add remaining channel.* topics
#457
Conversation
| /// The broadcaster login. | ||
| pub moderator_user_login: types::UserName, | ||
| /// The action being taken | ||
| #[serde(flatten)] |
There was a problem hiding this comment.
This is a bit unfortunate as it means that serde will parse unknown fields into some intermediate map, which is then passed to ActionV1::deserialize, because it doesn't know the fields of ActionV1.
| #[cfg_attr(feature = "deny_unknown_fields", serde(deny_unknown_fields))] | ||
| #[non_exhaustive] | ||
| pub struct ChannelModeratorAddV1 { | ||
| /// The broadcaster user ID for the channel you want to get moderator addition notifications for. |
There was a problem hiding this comment.
I feel like this can be worded better
There was a problem hiding this comment.
What about "The user ID for the channel you want to get moderator addition notifications for."? Or maybe even drop the "you want to ..." part? The text from the Twitch docs.
There was a problem hiding this comment.
the part im struggling with is moderator addition, but it's fine, just a nit
There was a problem hiding this comment.
I used "Get notifications when a {mod/vip} is {added/removed} in this channel".
| twitch_oauth2::Scope::ChannelReadGuestStar, | ||
| twitch_oauth2::Scope::ChannelManageGuestStar, | ||
| twitch_oauth2::Scope::ModeratorReadGuestStar, | ||
| twitch_oauth2::Scope::ModeratorManageGuestStart, // XXX: this is wrong |
Nerixyz
force-pushed
the
feat/small-eventsub
branch
from
866de1f to
f24439c
Compare
Nerixyz
force-pushed
the
feat/small-eventsub
branch
from
f24439c to
2172a22
Compare
Nerixyz
force-pushed
the
feat/small-eventsub
branch
from
2172a22 to
00248c0
Compare
Finally, all
channeltopics... I hope there aren't many typos and copy-paste errors.There's one typo in
twitch-oauth2I noticed, though 😔