feat: add a few new types #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
force-pushed
the
feat/more-types
branch
2 times, most recently
from
99158a8 to
7c52f8c
Compare
Emilgardis
requested changes
Oct 12, 2024
Cargo.toml
Outdated
Comment on lines
39
to
46
| entitlements = [] | ||
| moderation = ["serde"] | ||
| points = ["serde"] | ||
| stream = ["serde"] | ||
| timestamp = [] | ||
| user = ["serde"] | ||
| goal = ["serde"] | ||
| extensions = [] |
There was a problem hiding this comment.
should entitlements and extensions be plural or singular?
There was a problem hiding this comment.
Granted everything else except points is singular, I think they should be singular as well (diff).
Nerixyz
force-pushed
the
feat/more-types
branch
from
7c52f8c to
1034b49
Compare
Nerixyz
force-pushed
the
feat/more-types
branch
from
1034b49 to
4e805c6
Compare
Emilgardis
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few types from endpoints/topics we don't support yet. Additionally, it fixes a few rust/clippy warnings.
I didn't add a
GameId(e.g. inGet Game Analytics) since I'm not sure if that's the same as a category [?] (but seems to be different...).