Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Adding unknown state to lockfile parser. Adding support for metadata #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

garru
Copy link

@garru garru commented Dec 20, 2010

for the gemfile below "version: 1.0.6" was added as a dependency. this patch fixes it so that new gemfile types will not mess up parsing, by adding a new state "unknown"

GEM
specs:
activesupport (2.3.9)
fauna-mysql (2.8.1.3)
kgio (2.0.0)
memcached (0.17.4)
tbird-client (0.1.0)
thrift (0.2.0)
thrift_client (0.4.0)
thrift

PLATFORMS
ruby

DEPENDENCIES
activesupport (< 3.1)
fauna-mysql (= 2.8.1.3)
kgio (= 2.0.0)
memcached (= 0.17.4)
tbird-client (= 0.1.0)
thrift (= 0.2.0)
thrift_client (= 0.4.0)

METADATA
version: 1.0.6

@freels
Copy link
Contributor

freels commented Dec 20, 2010

Apparently bundler 1.0.6 was pulled because this metadata block was completely broken. Older versions of bundler tried to install the gem "version" or something. 1.0.7 fixed this. I'm not sure if bundler will use the same metadata section in later versions. (Though we should pull this in if that's the case, or modified if not.)

@garru
Copy link
Author

garru commented Dec 21, 2010

i don't really care about the metadata. do you want me to repatch with just the unknown state fix?

@freels
Copy link
Contributor

freels commented Dec 21, 2010

Yeah, that sounds reasonable, though perhaps we should bail if we don't know what a section means?

@garru
Copy link
Author

garru commented Dec 21, 2010

all spitball cares about are dependencies right? if they decide to add back the metadata section or maybe an even more innocuous hypothetical comments section do you want spitball to just raise something like "unknown Gemfile.lock format?"

i ran into this problem when trying to use spitball with a gemfile generated with bundler 1.0.6 and i got a "run bundle install" error. so i just want to help the next person.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Gary seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants