Test for compiler_args in thrift_library #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md to reflect fork status
…s-from-upstream Pull changes from upstream
Pull Commits from bazelbuild/rules_scala master
…uild#1103) * Don't use misleading depset in doc string * Remove unused ScalacProvider loads and mentions
* Add jmh deps toolchain * Add JMH library deps to toolchain * Add jmh core to deps toolchain
* Add testing toolchain with Junit deps * Add docs for junit * Update junit related aspect test deps
* Added ability to configure reporter class * Added test for "reporter_class" option * Added e2e test (bash script) which checks output file from Custom report * Added test_custom_reporter_class.sh to test_rules_scala.sh * Fix lint
* Add scalatest deps to testing toolchain * Update testing docs, toolchain and repository loading * Fix aspect test * Add testing toolchain to version tests WORKSPACE * Update testing toolchain docs
bazelbuild#1113) * Move external artifact versions and shas to central place per Scala version * Move scalafmt deps to repositories * Move jmh deps to repositories * Move junit deps to repositories * Move specs2 deps to repositories * Move specs2-junit deps to repositories * Move proto deps to repositories * Move tut deps to repositories * Move scrooge deps to repositories * Move WORKSPACE test deps to repositories files * Move dep back to workspace to explicitly use jvm_maven_import_external, to address dep analyzer tests * Fix Scala version tests * Use repository deps for scrooge * Add scrooge version tests back * Keep current twitter scrooge repository interface
* Fix scalac label for scala_proto_library When building scala_proto_library in users workspace then local labels are incorrectly prefixed with @io_build_rules_scala * Add .bazelversion to prevent downloads * Align bazel version with other tests
* Inject Scalapb deps via providers on the toolchain * Update scalapb toolchain deps docs * Lint * Use external names for default labels * Add proto toolchain only for deps `//scala_proto:deps_toolchain_type` is required to uncycle dependency between `//scala_proto:toolchain_type` and generators which depend on the same proto libraries and need to be initialized before the toolchain creation. * Update toolchain transitions * Use incompatible_use_toolchain_transition
* Add neverlink support * Fix tests meaning
* Add scrooge toolchain * Rename dep provider for scrooge generator * Migrate thrift and scrooge rules cfg from host to exec * Add test to ensure scrooge host and target deps are not mixed
* Pass scalac as executable * Add scalac to tools maybe this will resolve runfiles * proto toolchain exposes ctx.attr.scalac.files_to_run * change scalac cfg host -> exec
* Testing short test timeout * Now using realistic timeout
* Update docs for proto toolchain * Clarify when to use toolchains
* Fix toolchain registration call for ScalaTest * Use external name in toolchain registration * Add example/integration test for ScalaTest repositories * Use the same skylib version and download it from google mirror * Update rules_go to support 1.0.3 skylib
* Add scala config repository to store global configuration options * Fix example workspace * Add docs * Get bazel version directly * Remove unused skylib load
* Update testing docs, toolchain and repository loading * Add testing toolchain to version tests WORKSPACE * specs2 and specs2 junit toolchain deps * Use external name in toolchain helpers * Update and add specs2 docs and examples * Docs update * Remove duplicate toolchain registration * Move example workspace tests to a separete Travis CI job * Fix typo in docs
* Update scalatest to version 3.1.2 * Update coverage.dat file in tests
* Use released protoc binaries Avoid compiling protoc during bazel build. Based on change in rules_proto bazelbuild/rules_proto#36 rules_proto_dependencies() declares a @com_google_protobuf//:protoc which points to released protoc binary. The tricks is to load that before scala_repositories() which has conditional load for @com_google_protobuf * lint fix * Align rules_proto versions * Update readme * Revert "Update readme" This reverts commit b9a3606.
… version 20.9.0 (bazelbuild#1139) * Update scrooge and util to v 20.9.0 for scala 2.12 * Update scrooge and util to v 20.9.0 for scala 2.11 * Update test_version script to use scrooge version 20.9.0 * Fix tests errors * Remove scalatest update
…ter-forks#6) * Add option parsing file * Add OptionParser * Add scopt dependency * Lint reformat
blorente
force-pushed
the
master
branch
2 times, most recently
from
45044bf
to
19c6a71
Compare
cattibrie
force-pushed
the
master
branch
3 times, most recently
from
1125957
to
c8f5d3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
Tests for changes in PR #6