Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky tests #142

Open
thinkingfish opened this issue Mar 15, 2017 · 3 comments
Open

fix flaky tests #142

thinkingfish opened this issue Mar 15, 2017 · 3 comments

Comments

@thinkingfish
Copy link
Contributor

Add a mock timer for tests that rely on timing, such as pipe tcp timewheel, these occasionally fail due to timing issues.

@thinkingfish

This comment was marked as spam.

@thinkingfish

This comment was marked as spam.

@brayniac
Copy link
Contributor

Seeing periodic flakey tests on the linux gcc builds.

	  4 - check_pipe (Failed)
	  5 - check_tcp (Failed)
Errors while running CTest
Makefile:85: recipe for target 'test' failed
make: *** [test] Error 8
_build/test/channel/tcp/tcp.log:/home/travis/build/twitter/ccommon/test/channel/tcp/check_tcp.c:335:F:tcp test:test_nonblocking:0: Assertion 'duration_us(&duration) >= 500000' failed: duration_us(&duration) == 499977, 500000 == 500000
_build/test/channel/pipe/pipe.log:/home/travis/build/twitter/ccommon/test/channel/pipe/check_pipe.c:129:F:pipe test:test_read_blocking:0: Assertion 'duration_us(&duration) >= 500000' failed: duration_us(&duration) == 499959, 500000 == 500000
Build failure```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants