Change check_pipe to use nanosleep instead of usleep #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swlynch99
pushed a commit
to swlynch99/pelikan-twitter
that referenced
this pull request
Nov 19, 2019
swlynch99
pushed a commit
to twitter/pelikan
that referenced
this pull request
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
check_pipe is flaky on travis since occasionally it doesn't sleep for the necessary amount of time. (see #142). This showed up in the build logs of #230.
Solution
Rewrite the sleep loop to use nanosleep so that we can retry with the correct time when interrupted.
Result
Hopefully the tests won't be as flaky.