Cleanup libcheck related code #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
michalbiesek
commented
Sep 9, 2019
•
michalbiesek
commented
- Ref Clean up libcheck related code in CMake file, similar to how it is done in Pelikan #202, twitter/pelikan@14fcd34
- Replace CHECK_WORKING with CHECK_FOUND
- call make test instead of make check
- Fix Cmake warning "Policy CMP0075" by remove CMAKE_REQUIRED_LIBRARIES
michalbiesek
force-pushed
the
feat-check-clenaup
branch
5 times, most recently
from
7630f41 to
ef69546
Compare
- Ref twitter#202, twitter/pelikan@14fcd34 - Replace CHECK_WORKING with CHECK_FOUND - call make test instead of make check - Fix Cmake warning "Policy CMP0075" by remove CMAKE_REQUIRED_LIBRARIES
michalbiesek
force-pushed
the
feat-check-clenaup
branch
from
ef69546 to
cebd184
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.