Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check log multithread safeness #93

Closed
wants to merge 1 commit into from

Conversation

seppo0010
Copy link
Contributor

Fixes #92

@thinkingfish

This comment was marked as spam.

@paegun
Copy link
Contributor

paegun commented Apr 6, 2016

@thinkingfish the general opinion about testing race conditions is generally considering only what can be done w/i the system under test and test. So the general opinion is leaving out the testing framework and/or compiler-provided tools. Since clang is used, if present, TSan ( http://clang.llvm.org/docs/ThreadSanitizer.html ) should be considered.

@thinkingfish

This comment was marked as spam.

@paegun
Copy link
Contributor

paegun commented Apr 7, 2016

@thinkingfish I think the tsan documentation leads too much towards c++11, but clang (C) and clang++(C++) both have tsan integration. I've posted the following gist which demonstrates via a small example tsan in C: https://gist.github.com/785c726acf592ef91137bd90614e1ede

If I'm not understanding "doesn't support libc" properly, sorry. My experience w/ tsan in a C codebase has been limited to portability only to a few linux variants.

@thinkingfish

This comment was marked as spam.

@paegun
Copy link
Contributor

paegun commented Apr 7, 2016

@thinkingfish I've updated the gist to include gcc 4.8 and the undocumented bits required to use tsan.

@seppo0010 sorry for the general thread testing commentary on this specific PR, which looks great.

@seppo0010 seppo0010 closed this May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test log thread-safeness
3 participants