Use xcframework distribution of WebP #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bug tracking changes needed for the headers of the XCFramework bundles - https://bugs.chromium.org/p/webp/issues/detail?id=542#c1 |
|
The bug with the way that XCFramework bundles were packaged has been resolved in 1.2.2, which is currently in RC with an expected release of early Q1 2022. When it happens, I'll update this fork to use the official release although there is not really any difference. |
|
1.2.2 was officially released with the working .xcframework bundles available to download from here: http://storage.googleapis.com/downloads.webmproject.org/releases/webp/libwebp-1.2.2-ios-framework.tar.gz In 5008013, I just copied those versions into this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Twitter 👋
As I am sure that you are aware, TIP had to make some compromises for WebP support and Mac Catalyst since no xcframework distribution of WebP existed. I'm happy to announce however that starting with 1.2.0, this is no longer the case!
https://groups.google.com/a/webmproject.org/g/webp-discuss/c/LwWaVfKbJGc/m/IjpeggKnAAAJ
https://storage.googleapis.com/downloads.webmproject.org/releases/webp/index.html
With xcframeworks, we no longer need to both support both compiling webp as well as using precompiled frameworks. In this pull-request I take a first attempt at getting it up and running.
Why
How
I'm able to achieve this by doing the following:
1.2.11.2.2 release of WebP direct from the source'Patch'/'Modify' the headers in the .xcframeworks file (more info here)pod spec lintWhat Next?
Firstly, i'm not sure if you are happy just using the binaries that I have pushed in this PR.. Please feel free to download again from the link above and apply the modifications in step 2 yourself.
Secondly, I from what I gather, Twitter might not use this repository directly internally so you might want to land this change in some other way? I've verified that all of the targets in the TwitterImagePipeline Xcode Project compile and run the tests as expected. I've also verified in my own project which uses both TIP and the WebP Codec via the CocoaPods integration that things work as expected!
Thanks again! Please let me know if there is anything else that I can do to help