Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HTTP protocol #469

Merged
merged 17 commits into from
Oct 3, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add request parsing tests
swlynch99 committed Oct 3, 2022

Verified

This commit was signed with the committer’s verified signature. The key has expired.
renovate-bot Mend Renovate
commit d11c67f1b05a80eda823f9804547b5f711071522
7 changes: 7 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/protocol/http/Cargo.toml
Original file line number Diff line number Diff line change
@@ -15,3 +15,6 @@ phf = { version = "0.11.1", features = ["macros"] }

protocol-common = { path = "../common" }
logger = { path="../../logger" }

[dev-dependencies]
assert_matches = "1.5.0"
104 changes: 104 additions & 0 deletions src/protocol/http/tests/request.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,104 @@
use assert_matches::assert_matches;
use protocol_http::{Error as ParseError, Request, RequestData, RequestParser};

fn parse_to_end(data: &[u8]) -> protocol_http::Result<Request> {
let mut buffer = data;

let parser = RequestParser::new();
let request = parser.do_parse(&mut buffer)?;

assert_eq!(buffer.len(), 0);
assert!(
buffer.as_ptr() == data.as_ptr().wrapping_add(data.len()),
"buffer did not point to end of data slice"
);

Ok(request)
}

#[test]
fn parse_get() {
let data: &[u8] = b"\
GET /test HTTP/1.1\r\n\
Server: no\r\n\
\r\n\
";

let request = parse_to_end(data).expect("failed to parse request");
let key = assert_matches!(request.data(), RequestData::Get(key) => key);

assert_eq!(key, b"/test");
}

#[test]
fn parse_put() {
let data: &[u8] = b"\
PUT /test HTTP/1.1\r\n\
Content-Length: 10\r\n\
Test: blah\r\n\
\r\n\
abcdefghij\
";

let request = parse_to_end(data).expect("failed to parse request");
let (key, value) =
assert_matches!(request.data(), RequestData::Put(key, value) => (key, value));

assert_eq!(key, b"/test");
assert_eq!(value, b"abcdefghij");
}

#[test]
fn parse_delete() {
let data: &[u8] = b"\
DELETE /test HTTP/1.1\r\n\
Test: blah\r\n\
\r\n\
";

let request = parse_to_end(data).expect("failed to parse request");
let key = assert_matches!(request.data(), RequestData::Delete(key) => key);

assert_eq!(key, b"/test");
}

#[test]
fn parse_header_case_insensitive() {
let data: &[u8] = b"\
GET /blah HTTP/1.1\r\n\
Test: yes\r\n\
\r\n\
";

let request = parse_to_end(data).expect("failed to parse request");

assert_eq!(request.header("test"), Some("yes".as_bytes()));
assert_eq!(request.header("Test"), Some("yes".as_bytes()));
assert_eq!(request.header("tEsT"), Some("yes".as_bytes()));
}

#[test]
fn parse_key_urlencoded() {
let parser = RequestParser::new();
let mut data: &[u8] = b"\
GET /%21%40%23%24%25%5E%26%2A%28%29 HTTP/1.1\r\n\
\r\n\
";

let request = parser.do_parse(&mut data).expect("failed to parse request");
let key = assert_matches!(request.data(), RequestData::Get(key) => key);

assert_eq!(key, b"/!@#$%^&*()");
}

#[test]
fn parse_incomplete() {
let data: &[u8] = b"\
PUT /aaaaaa HTTP/1.1\r\n\
Content-Length: 100\r\n\
\r\n\
";
let result = parse_to_end(data);

assert_matches!(result, Err(ParseError::PartialRequest(Some(100))));
}