added requiredBinarayComparators

[MansurAshraf]

No description provided.

[johnynek]

can we change the name of this to say, orderedSerialization? Scala has this issue (bug?) where if you have two implicits in scope of the same name you get issues:

scala> object Test { implicit val name: String = "object" }
defined module Test

scala> trait TestT { implicit val name: String = "trait" }
defined trait TestT

scala> class TestClass extends TestT { import Test._; println(implicitly[String]) }
<console>:9: error: could not find implicit value for parameter e: String
       class TestClass extends TestT { import Test._; println(implicitly[String]) }
                                                                        ^

scala> import Test._
import Test._

scala> class TestClass extends TestT { println(implicitly[String]) }
defined class TestClass

scala> new TestClass
trait
res0: TestClass = TestClass@20c9cd89

scala> class TestClass extends TestT { import Test._; println(implicitly[String]) }
<console>:12: error: could not find implicit value for parameter e: String
       class TestClass extends TestT { import Test._; println(implicitly[String]) }
                                                                        ^

scala> object Test2 { val name2: String = "Test2" }
defined module Test2

scala> class TestClass extends TestT { import Test2._; println(implicitly[String]) }
defined class TestClass

scala> new TestClass
trait
res1: TestClass = TestClass@3ba4236f

[johnynek]

merge when green

[MansurAshraf]

closing this and moving the change to #1338 in order to use thrift macro

[johnynek]

PS: you wasted the 1337 PR. :( you could have been so leet!