Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added type hinting and improved code formatting. #1815

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Added type hinting and improved code formatting. #1815

wants to merge 6 commits into from

Conversation

ijsbol
Copy link

@ijsbol ijsbol commented May 4, 2023

It was not fun to figure out where the hell DefaultSubcommandArgParse comes from.
Twitter, please learn what type hinting is.

@CLAassistant
Copy link

CLAassistant commented May 4, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ijsbol ijsbol changed the title Added type hinting and code formatting. Added type hinting and improved code formatting. May 4, 2023
@Siddhesh-Agarwal
Copy link

I worked on fixing type hinting extensively. Here is my PR: #1789. Do you mind merging your PR with this repo?

That way we can give a big PR that fixes everything.

@ijsbol
Copy link
Author

ijsbol commented Jun 12, 2023

Done https://github.com/Siddhesh-Agarwal/the-algorithm/pull/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ijsbol @CLAassistant @Siddhesh-Agarwal