Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Martinique Country Flag #1116

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

thierryc
Copy link

This pull request addresses issue #623 by updating the Martinique flag. It replaces the previous pull request #624.

•	The new flag has been redrawn and optimized.
•	Both the SVG and PNG versions have been updated.
•	The flag is now centered vertically and rounded, ensuring consistency with other Twemoji flags.

This update ensures that the Martinique flag matches the visual style of the rest of the emoji set.

The source is Wikipedia

https://commons.wikimedia.org/wiki/File:Flag-of-Martinique.svg

https://en.wikipedia.org/wiki/Martinique

image

@Mercury13
Copy link

I would redo the SVG a bit: it is not optimized for deficiencies of SVG renderers.

  1. If two filled spaces are together, one should overlap another.
  2. If they meet at the edge, this overlap should go away from edge.

@Mercury13
Copy link

About 2 — there’s an exception: one of the filled spaces is really small. E.g. Sweden: just draw the cross, blue fringe is almost invisible and is even part of style.

@thierryc
Copy link
Author

Thanks for the insightful comments, @Mercury13! I’ll definitely follow your advice and update my PR accordingly.

@thierryc
Copy link
Author

Hi @Mercury13

I’m looking for some advice on how to effectively overlap two shapes. I have two options in mind:

  1. Slight Overlap: Make one shape slightly larger than the other, allowing for a few pixels of overlap.
  2. Full Overlap: Completely overlap one shape over the background shape.

Which approach do you think would work best? Any insights or recommendations would be greatly appreciated! Thanks!

image image

@thierryc
Copy link
Author

Hi @Mercury13,
I’ve updated the SVG file to include the “Full Overlap” option, where one shape completely overlaps the background shape.
Could you please confirm if this is the correct implementation? Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants